[webkit-reviews] review granted: [Bug 39810] new-run-webkit-tests: Support DRT on Chromium-win : [Attachment 57310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 07:06:00 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 39810: new-run-webkit-tests: Support DRT on Chromium-win
https://bugs.webkit.org/show_bug.cgi?id=39810

Attachment 57310: Patch
https://bugs.webkit.org/attachment.cgi?id=57310&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I like this refactoring, it makes management of the output code easier. We
should probably do the same thing in the DRT proper -- but not today.


WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:49
 +  # Chromium DRT on non-Windows uses WebKitDriver.
I am curious how platform/win DRT works then?


More information about the webkit-reviews mailing list