[webkit-reviews] review denied: [Bug 39721] [chromium] Upstream layout tests expectations for Geolocation. : [Attachment 57324] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 06:49:27 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 39721: [chromium] Upstream layout tests expectations for Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=39721
Attachment 57324: Patch
https://bugs.webkit.org/attachment.cgi?id=57324&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.
txt:1
+ CONSOLE MESSAGE: line 22: Uncaught Error: Exception in success callback
This worries me some. Does it show up with JSC? I feel like maybe you could
catch the exception in the test.
LayoutTests/ChangeLog:9
+ *
platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt: Added.
Does this work? I believe you have to add it to -win and -mac. Dimitri has
confirmed this in the past. But, now that I think about it, maybe that's
silly? Especially if this works. (Are you sure it does?)
More information about the webkit-reviews
mailing list