[webkit-reviews] review denied: [Bug 38851] Large SVG rect with shadow fails to render : [Attachment 57264] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 03:05:22 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 38851: Large SVG rect with shadow fails to render
https://bugs.webkit.org/show_bug.cgi?id=38851
Attachment 57264: Patch
https://bugs.webkit.org/attachment.cgi?id=57264&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hey Rob,
the ChangeLog needs an update, you're not using intermediate values anymore :-)
Almost r+, but you've said that there are results that have changed, and the
pixel tests stayed the same? Sounds awkward to me, did you use
"run-webkit-tests --tolerance 0 -p svg" ?
If there are changes, please update a full patch with all changes.
Sorry for the new round...
Cheers,
Niko
More information about the webkit-reviews
mailing list