[webkit-reviews] review granted: [Bug 39828] document.write does not work correctly in the HTML5 parser : [Attachment 57305] Updated to TOT and removed tabs

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 39828: document.write does not work correctly in the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39828

Attachment 57305: Updated to TOT and removed tabs
https://bugs.webkit.org/attachment.cgi?id=57305&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Wow, that's very pretty.  :)  Some comments below.

WebCore/ChangeLog:12
 +	    before calling ScriptControlle::executeScript to allow safe
ScriptControlle -> ScriptController

WebCore/html/HTML5Tokenizer.cpp:42
 +	, m_docuemnt(document)
m_docuemnt -> m_document

WebCore/html/HTML5Tokenizer.cpp:120
 +	// not an already-loaded CachedResource.
There's some grammar problems here.

WebCore/html/HTML5Tokenizer.cpp:131
 +	// Not currently possible to execute scripts on frameless documents.
It's not so much that it's not possible.  We explicitly don't want to.

WebCore/html/HTML5Tokenizer.cpp:135
 +	SegmentedString oldInsertionPoint = m_source;
How expensive is this copy?  Maybe we should use OwnPtr and swap?