[webkit-reviews] review denied: [Bug 39857] GIFs loop one time too few : [Attachment 57285] patch v1.1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 39857: GIFs loop one time too few
https://bugs.webkit.org/show_bug.cgi?id=39857

Attachment 57285: patch v1.1
https://bugs.webkit.org/attachment.cgi?id=57285&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Great catch, really glad you are fixing it.

Why get rid of cAnimationLoopOnce? Changing its value to 0 would make the patch
smaller, and I think having a named constant for it is still helpful even if
it's only a particular special case of the general rule of "loop once more than
this number". I think that changing from the constant to the magic number 0
makes the code less readable.

Please take a crack at doing this without removing cAnimationLoopOnce. The
resulting patch should be a bit smaller and it will also be clearer what you
are and are not changing.