[webkit-reviews] review granted: [Bug 32123] cursor movement and text selection does not work well if a block is followed by an inline : [Attachment 51722] v1; made the test case self-descriptive

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 32123: cursor movement and text selection does not work well if a block is
followed by an inline
https://bugs.webkit.org/show_bug.cgi?id=32123

Attachment 51722: v1; made the test case self-descriptive
https://bugs.webkit.org/attachment.cgi?id=51722&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Please add the FIXME before propagating up to the containingBlock in
RenderBoxModelObject. 

>From #webkit:
ojan: dhyatt: added the assert. the end of the selection is a RenderInline
dhyatt: yeah unsurprising
dhyatt: i guess the patch is ok... let's just put a FIXME in asking whether we
should consider propagating to ancestor RenderInlines
dhyatt: but for now we can just leave everything jumping out to the containing
block
dhyatt: i suppose you could say selection consists of the start, end, leaves,
and their containing blocks 
dhyatt: where the start/end violate the leaf rule