[webkit-reviews] review denied: [Bug 34995] Refactor DB layout tests so that they work in Web Workers as well as Pages. : [Attachment 56933] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 34995: Refactor DB layout tests so that they work in Web Workers as well as
Pages.
https://bugs.webkit.org/show_bug.cgi?id=34995

Attachment 56933: Patch
https://bugs.webkit.org/attachment.cgi?id=56933&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Sorry it takes too long.

LayoutTests/storage/multiple-databases-garbage-collection.js:27
 +	persistentDB = openDatabase("MultipleDatabasesTest1", "1.0", "Test one
out of a set of databases being destroyed (1)", 32768);
+ DB_TEST_SUFFIX here?

LayoutTests/storage/multiple-databases-garbage-collection.js:28
 +	forgottenDB = openDatabase("MultipleDatabasesTest2", "1.0", "Test one
out of a set of databases being destroyed (2)", 32768);
same

LayoutTests/storage/multiple-transactions-on-different-handles.js:13
 +	return openDatabase("MultipleTransactionsOnDifferentHandlesTest",
+ DB_TEST_SUFFIX
Maybe there should be a single function somewhere in database-common.js to make
sure the suffix is not forgotten in each test, and perhaps simply a variable
for each test containing the desired name of the database? Perhaps
openTestDatabase can be repurposed to be this common function...

r- to add the suffix and please consider a common function that does this.