[webkit-reviews] review denied: [Bug 39701] UTF-16 code points compare() for String objects : [Attachment 57251] patch 5

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 39701: UTF-16 code points compare() for String objects
https://bugs.webkit.org/show_bug.cgi?id=39701

Attachment 57251: patch 5
https://bugs.webkit.org/attachment.cgi?id=57251&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   friend int codePointCompare(const UString&, const UString&);

There's no need for this function to be a friend.

> +    inline int codePointCompare(const UString& s1, const UString& s2)
> +    {
> +	   return codePointCompare(s1.m_rep.get(), s2.m_rep.get());
> +    }

This can use the rep() function instead of getting at m_rep directly.

r=me if you remove the unnecessary friendship