[webkit-reviews] review denied: [Bug 35551] Hardcoding of /usr/bin/gcc in perl build scripts : [Attachment 57197] remove hardcoded refs to gcc's path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 12:55:01 PDT 2010


David Levin <levin at chromium.org> has denied Lucas De Marchi
<lucas.demarchi at profusion.mobi>'s request for review:
Bug 35551: Hardcoding of /usr/bin/gcc in perl build scripts
https://bugs.webkit.org/show_bug.cgi?id=35551

Attachment 57197: remove hardcoded refs to gcc's path
https://bugs.webkit.org/attachment.cgi?id=57197&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This patch doesn't do this "Perhaps you could use the environment variable if
it exists, and otherwise use the hardcoded path" as suggested in the comments.

Also, the variable name change is superfluous (and without that change, less
lines of code are changed).


More information about the webkit-reviews mailing list