[webkit-reviews] review granted: [Bug 39606] Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled when encoding is Japanese : [Attachment 56906] proposed patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 39606: Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled
when encoding is Japanese
https://bugs.webkit.org/show_bug.cgi?id=39606

Attachment 56906: proposed patch
https://bugs.webkit.org/attachment.cgi?id=56906&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, except for a few style nitpicks.

LooksLayoutTests/fast/encoding/yentest.html:13
 +  // document.write("one backslash inline: " + "\" + "<br>");
We can remove this line?

LayoutTests/fast/encoding/resources/yentestexternal2.js:2
 +  document.write("two backslashes external: \\ <br>");
It would be better to indent lines in functions.


LayoutTests/fast/encoding/resources/yentestexternal2.js:1
 +  function writeYenExternal() {
It would be better to break line between () and { to be consistent with C++
coding style.

LayoutTests/fast/encoding/resources/yentestexternal.js:1
 +  function writeYenExternal() {
The same comment as yenexternal2.js