[webkit-reviews] review granted: [Bug 39372] check-webkit-style complains about use of NULL in GTK function calls that require sentinels : [Attachment 57212] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 03:01:18 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 39372: check-webkit-style complains about use of NULL in GTK function calls
that require sentinels
https://bugs.webkit.org/show_bug.cgi?id=39372

Attachment 57212: proposed patch
https://bugs.webkit.org/attachment.cgi?id=57212&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, but it would be better if we can limit the symbols. How about
r'\bg_[a-z]+_[a-z]+\b', r'\bg_[a-z]+(_[a-z]+)+\b', or r'\bg(_[a-z]+)+\b' ?


More information about the webkit-reviews mailing list