[webkit-reviews] review granted: [Bug 39802] Implement SegmentedString::lookAheadSlowCase : [Attachment 57191] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39802: Implement SegmentedString::lookAheadSlowCase
https://bugs.webkit.org/show_bug.cgi?id=39802

Attachment 57191: Patch
https://bugs.webkit.org/attachment.cgi?id=57191&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   *consumedCharacters++ = *current();

Just a nitpick: I would write:

    consumedCharacters[i] = *current();

But the two are equivalent.

> +	   if (string.length() > length())
> +	       return NotEnoughCharacters;
> +	   unsigned count = string.length();

If you set up count one line earlier then you wouldn't have to evaluate
string.length() twice.

> +	   UChar* consumedCharacters = 0;

No need to initialize to zero here.

r=me