[webkit-reviews] review granted: [Bug 39706] Make more HTML DOM members private, especially constructors, batch 2 : [Attachment 57064] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 39706: Make more HTML DOM members private, especially constructors, batch 2
https://bugs.webkit.org/show_bug.cgi?id=39706

Attachment 57064: Patch
https://bugs.webkit.org/attachment.cgi?id=57064&action=review

------- Additional Comments from David Levin <levin at chromium.org>
WebCore/html/HTMLKeygenElement.cpp:52
 +	    RefPtr<HTMLOptionElement> o = HTMLOptionElement::create(optionTag,
document, this->form());
Consider adding a constructor for HTMLOptionElement which doesn't need to be
passed "optionTag" as you did in other places in this patch and the previous
one.



WebCore/html/HTMLOptGroupElement.cpp: 
 +	bool result = HTMLFormControlElement::insertBefore(newChild, refChild,
ec, shouldLazyAttach);
I wonder if "HTMLFormControlElement::insertBefore" is used anywhere now (ditto
for the other method calls that were removed here).