[webkit-reviews] review requested: [Bug 39786] Public GIF decoder fails to mark some images as "done" : [Attachment 57165] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 26 15:01:04 PDT 2010


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 39786: Public GIF decoder fails to mark some images as "done"
https://bugs.webkit.org/show_bug.cgi?id=39786

Attachment 57165: patch v1
https://bugs.webkit.org/attachment.cgi?id=57165&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This patch fixes both places that failed to use GETN() to change state: one by
using the macro, and the other by eliminating it entirely.  (WebKit uses this
code differently than Mozilla did, and marking corrupt GIFs as "failed" won't
prevent their display.)


More information about the webkit-reviews mailing list