[webkit-reviews] review granted: [Bug 39446] Video elements show no video on Windows machines that do not support accelerated compositing : [Attachment 57138] Patch (Part2)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 39446: Video elements show no video on Windows machines that do not support
accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39446

Attachment 57138: Patch (Part2)
https://bugs.webkit.org/attachment.cgi?id=57138&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 60251)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,23 @@
> +2010-05-26  Jer Noble  <jer.noble at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +		Video elements show no video on Windows machines that do not
support accelerated compositing
> +		https://bugs.webkit.org/show_bug.cgi?id=39446
> +		rdar://problem/7999794
> +		

TABS!


> +    CFDictionaryRef options = 0;
> +    // If CAImageQueue prerequisites are not satisfied, pass in visual
context pixelbuffer
> +    // options which will instruct the visual context to generate CGImage
compatible 
> +    // pixel buffers (i.e. RGBA).
> +    if (!requiredDllsAvailable() || preferredMode !=
MediaRenderingMovieLayer )

Extra space.

> +	   options = QTMovieVisualContext::getCGImageOptions();
> +    m_visualContext = adoptRef(new
QTMovieVisualContext(m_visualContextClient.get(), options));

This should use a create() method.

> +    m_visualContext->setMovie(m_movie.get());
>  }


>  QTMovieVisualContextPriv::~QTMovieVisualContextPriv()
>  {
> +	if (m_visualContext)
> +		QTVisualContextSetImageAvailableCallback(m_visualContext, 0,
0);
TABS!


Other than the nits. r=me.