[webkit-reviews] review denied: [Bug 39758] Heap::allocate should search a word at a time : [Attachment 57126] suggested patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Nathan Lawrence
<nlawrence at apple.com>'s request for review:
Bug 39758: Heap::allocate should search a word at a time
https://bugs.webkit.org/show_bug.cgi?id=39758

Attachment 57126: suggested patch
https://bugs.webkit.org/attachment.cgi?id=57126&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
+	     if (!~block->marked.bits[m_heap.nextCell >> 5])
+		 m_heap.nextCell = (m_heap.nextCell & (~0x1F)) + 32;

I think this code might be wrong on 64bit.

Also, would be nice to encapsulate these bitops in the CollectorBitmap
interface.

Let's talk about this in person.