[webkit-reviews] review denied: [Bug 39755] Make HTML5 lexer not ASSERT when resuming partial parses : [Attachment 57122] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39755: Make HTML5 lexer not ASSERT when resuming partial parses
https://bugs.webkit.org/show_bug.cgi?id=39755

Attachment 57122: Patch
https://bugs.webkit.org/attachment.cgi?id=57122&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is an excellent test to have.  However, I'm confused by the output.  Are
we running each script more than once?

 You should add a comment next to m_token as to why we need to hold it as a
member.

isEndTagBufferingState is almost big enough to justify using a hash.  Unclear.

Ok, so I love the patch.  My big concern is the test.  Why is this forked from
runner/webkit_runner.  Can we just add this functionality to one of those, or
does this need to be a copy of the javascript forever?

r- for the above nits.