[webkit-reviews] review denied: [Bug 39750] Allow peer frame navigation for file URLs when allowFileAccessFromFileURLs is false : [Attachment 57119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 26 11:57:52 PDT 2010


Adam Barth <abarth at webkit.org> has denied Justin Schuh <jschuh at chromium.org>'s
request for review:
Bug 39750: Allow peer frame navigation for file URLs when
allowFileAccessFromFileURLs is false
https://bugs.webkit.org/show_bug.cgi?id=39750

Attachment 57119: Patch
https://bugs.webkit.org/attachment.cgi?id=57119&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/loader/FrameLoader.cpp:2194
 +	    && targetFrame->document()->url().protocolIs("file")) {
We should be getting this information out of the securityOrigin() not out of
the document's URL.  Don't we just want to ask if securityOrigin()->isLocal() ?


More information about the webkit-reviews mailing list