[webkit-reviews] review granted: [Bug 39145] Add v8 bindings for async DB API in workers : [Attachment 56544] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 26 11:29:07 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 39145: Add v8 bindings for async DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=39145

Attachment 56544: Patch
https://bugs.webkit.org/attachment.cgi?id=56544&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Fantastic.  I love it.

WebCore/bindings/scripts/CodeGeneratorV8.pm:2150
 +	static PassRefPtr<${className}> create(v8::Local<v8::Value> value)
Nice.  Whenever we can remove Frame* from the bindings, we're doing something
right.

WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp:55
 +	v8::Handle<v8::Context> v8Context =
toV8Context(m_scriptExecutionContext.get(),
WorldContextHandle(UseCurrentWorld));
I'm not sure the "WorldContextHandle(UseCurrentWorld)" part is right.  Is there
other code that uses this pattern?


More information about the webkit-reviews mailing list