[webkit-reviews] review requested: [Bug 38279] Add CPP bindings generator : [Attachment 57076] Updated patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 26 01:21:32 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 38279: Add CPP bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38279

Attachment 57076: Updated patch v3
https://bugs.webkit.org/attachment.cgi?id=57076&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Fixed all issues reported by Sam and Kats, except one. I still export the
isMutationEvent etc. helper methods, as they're in use at the moment within
Olympia.
We'd like to generalize this, though I'd really love to see the patch
upstreamed first. We'll come back to it for sure. Hope that's okay, as it does
not affect other ports?


More information about the webkit-reviews mailing list