[webkit-reviews] review denied: [Bug 39092] Chromium/Mac: Add support for yank (ctrl-y) : [Attachment 57075] make stylebot happy(er)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 26 01:11:15 PDT 2010
Eric Seidel <eric at webkit.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 39092: Chromium/Mac: Add support for yank (ctrl-y)
https://bugs.webkit.org/show_bug.cgi?id=39092
Attachment 57075: make stylebot happy(er)
https://bugs.webkit.org/attachment.cgi?id=57075&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
We don't need this to be run-time switchable. So we should just make
KillRing.h non-virtual declarations and then add a KillRingNone.cpp which is
used by every non-mac port and has empty implementations.
We could also just use a killRing() helper function in KillRing.h which returns
a function-level static KillRing; which would then effectively be the killring.
Using a global function to access the killring like that makes mocking
harder... but we don't really have C++ unit testing in WebCore anyway. It
would get rid of the need to have any #ifdefs in editor since everywhere would
just call killRing() like it does now, but that would be a global function
returning the global killring object.
Otherwise this patch looks FANTASTIC. :)
More information about the webkit-reviews
mailing list