[webkit-reviews] review requested: [Bug 39146] [Qt] Pass all web notification layout tests : [Attachment 57062] Patch, remove the signal/slot and bring the patch up-to-date

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 19:03:52 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 39146: [Qt] Pass all web notification layout tests
https://bugs.webkit.org/show_bug.cgi?id=39146

Attachment 57062: Patch, remove the signal/slot and bring the patch up-to-date
https://bugs.webkit.org/attachment.cgi?id=57062&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
This patch is very similar to the previous one, just removing the signal/slot
suggested by Simon.
While I was waiting for dpranke to re-submit the notifications code that he
rolled out (r60193), I also implemented an icon loader for the notification
icon.
Should I combine the 2 patches?


More information about the webkit-reviews mailing list