[webkit-reviews] review granted: [Bug 39615] Implement basic column-span support : [Attachment 57044] Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 25 14:52:47 PDT 2010
mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 39615: Implement basic column-span support
https://bugs.webkit.org/show_bug.cgi?id=39615
Attachment 57044: Minor tweak - drop toRenderBlock casts when asking
isAnonymousColumnSpanBlock, since I made it a RenderObject method
https://bugs.webkit.org/attachment.cgi?id=57044&action=review
------- Additional Comments from mitz at webkit.org
WebCore/rendering/RenderBlock.cpp:287
+ RenderBlock* newBox = 0;
You don’t need to initialize this to 0. Or you could initialize it with a
ternary operator.
WebCore/rendering/RenderBlock.cpp:311
+ RenderBlock* newBox = 0;
Ditto.
Everything else is scary but fine.
r=me
More information about the webkit-reviews
mailing list