[webkit-reviews] review granted: [Bug 39684] Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp : [Attachment 57038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 13:03:22 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Brett Wilson
(Google) <brettw at chromium.org>'s request for review:
Bug 39684: Remove obsolete code from
WebKit/chromium/src/FrameLoaderClientImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=39684

Attachment 57038: Patch
https://bugs.webkit.org/attachment.cgi?id=57038&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 8593698..5fffb0d 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,14 @@
> +2010-05-25  Brett Wilson  <brettw at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remove obsolete code for Mac & Windows plugin creation in the
Chromium
> +	   port. This non-Windows code was to prevent a crash which we no
longer
> +	   seem to have, and it is preventing other types of plugins from
working.
> +

Add a bug reference here.

R=me


More information about the webkit-reviews mailing list