[webkit-reviews] review granted: [Bug 39681] Web Inspector: Fixes chromium crasher due to passing an empty handle to toWebCoreString() : [Attachment 57035] Fixes http://code.google.com/p/chromium/issues/detail?id=45004

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 12:05:47 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted jaimeyap at google.com's request
for review:
Bug 39681: Web Inspector: Fixes chromium crasher due to passing an empty handle
to toWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=39681

Attachment 57035: Fixes
http://code.google.com/p/chromium/issues/detail?id=45004
https://bugs.webkit.org/attachment.cgi?id=57035&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/bindings/v8/ScriptCallStack.cpp:75
 +	*functionName = toWebCoreString(functionNameValue.IsEmpty() ?
v8::Undefined() : functionNameValue);
You know what toWebCoreString from undefined will look like? (I am not sure).
Is that what you need?


More information about the webkit-reviews mailing list