[webkit-reviews] review denied: [Bug 39418] history.pushState doesn't work for the first page in a window. : [Attachment 57020] layout test v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 09:10:07 PDT 2010


Brady Eidson <beidson at apple.com> has denied  review:
Bug 39418: history.pushState doesn't work for the first page in a window.
https://bugs.webkit.org/show_bug.cgi?id=39418

Attachment 57020: layout test v1
https://bugs.webkit.org/attachment.cgi?id=57020&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
I'm r-'ing because I'm missing how this test actually works under the
run-webkit-tests harness.

Yes, if I open it in a new Safari window, for example, it would be exercising
the code path that used to have this problem.

But run-webkit-tests reuses the same WebView for a series of tests.  Therefore
- unless it goes first - this test won't actually excercise the buggy code
path.


More information about the webkit-reviews mailing list