[webkit-reviews] review denied: [Bug 39663] Update the style guide re: static member variables and structs : [Attachment 56995] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 25 08:55:15 PDT 2010
Darin Adler <darin at apple.com> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 39663: Update the style guide re: static member variables and structs
https://bugs.webkit.org/show_bug.cgi?id=39663
Attachment 56995: Patch
https://bugs.webkit.org/attachment.cgi?id=56995&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> -<li>Prefix C++ data members with "m_".
> +<li>Prefix C++ class member variables with "m_" and do not make them public.
The term "data members" is correct C++ terminology. The term "member variables"
is not correct C++ terminology. I would write:
Prefix C++ data members with "m_" and static data members with "s_" and do
not make them public
> +<li>Static member variables should be prefixed with "s_".</li>
The correct term is "static data members".
More information about the webkit-reviews
mailing list