[webkit-reviews] review denied: [Bug 39593] [Android] Add IndexedDB to the build : [Attachment 56877] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 08:09:25 PDT 2010


Steve Block <steveblock at google.com> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 39593: [Android] Add IndexedDB to the build
https://bugs.webkit.org/show_bug.cgi?id=39593

Attachment 56877: Patch
https://bugs.webkit.org/attachment.cgi?id=56877&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
WebCore/Android.derived.jscbindings.mk:370
 +	$(intermediates)/storage/IndexedDatabaseRequest.h
These should be JSIDBFoo.h

WebCore/Android.derived.v8bindings.mk:351
 +	$(intermediates)/storage/IndexedDatabaseRequest.h
These should be bindings/V8IDBFoo.h

WebCore/Android.mk:730
 +  ifeq ($(ENABLE_INDEXED_DATABASE), true)
No need for the guards, as the file contents are guarded anyway (the SVG guards
are just a legacy thing)


More information about the webkit-reviews mailing list