[webkit-reviews] review denied: [Bug 39487] Add a skeleton 'speech' type input element : [Attachment 57015] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 39487: Add a skeleton 'speech' type input element
https://bugs.webkit.org/show_bug.cgi?id=39487

Attachment 57015: Patch
https://bugs.webkit.org/attachment.cgi?id=57015&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebInputElement.h:79
 +  #if (defined ENABLE_INPUT_SPEECH && ENABLE_INPUT_SPEECH)
This #if should be removed.  Any conditional code needs to be in
the .cpp file.	Since this is an enum that needs to match the one
declared in WebCore, I recommend not wrapping the WebCore one with
an #if either.

The consumers of the Chromium WebKit API do not necessarily include
config.h, so they may not have access to the set of enabled features.
Therefore, we do not support feature defines in the public interface.