[webkit-reviews] review denied: [Bug 39618] Allow embedding applications to decide what is or isn't an application specific plugin type : [Attachment 56925] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 15:30:08 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Gregory Dardyk
<gregoryd at google.com>'s request for review:
Bug 39618: Allow embedding applications to decide what is or isn't an
application specific plugin type
https://bugs.webkit.org/show_bug.cgi?id=39618

Attachment 56925: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=56925&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/ChromiumBridge.cpp:471
 +  // MimeType
-------------------------------------------------------------------
nit: please preserve the new line that followed this comment.

WebKit/chromium/src/ChromiumBridge.cpp:474
 +	return webKitClient()->mimeRegistry()->isApplicationPluginMIMEType(
nit: webkit style is to just put this on one line.  exceeding 80 chars is ok!

r- due to style issues


More information about the webkit-reviews mailing list