[webkit-reviews] review granted: [Bug 39571] Teach the HTML5 parser to lex DOCTYPEs : [Attachment 56932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 14:58:37 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39571: Teach the HTML5 parser to lex DOCTYPEs
https://bugs.webkit.org/show_bug.cgi?id=39571

Attachment 56932: Patch
https://bugs.webkit.org/attachment.cgi?id=56932&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Would be nice if we had a version of this which took a const String& so we
didn't have to write "public" twice:

 1078			      advanceStringAndASSERTIgnoringCase(source,
"public");


othewrise looks good.

Seems silly to intentionally violate style just to match the spec wording.


More information about the webkit-reviews mailing list