[webkit-reviews] review denied: [Bug 39571] Teach the HTML5 parser to lex DOCTYPEs : [Attachment 56923] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39571: Teach the HTML5 parser to lex DOCTYPEs
https://bugs.webkit.org/show_bug.cgi?id=39571

Attachment 56923: Patch
https://bugs.webkit.org/attachment.cgi?id=56923&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5Lexer.cpp:891
 +			source.advanceAndASSERTIgnoringCase('d');
Seems it would be simple to write a little helper method (static inline) which
did:

static inline void advanceAndASSERTIgnoringCase(SegmentedString& string, char*
assertionString)
{
    for (int x = 0;; x++) {
	if (!assertionString[x])
	     return;
	string.advanceAndASSERTIngoringCase(assertionString[x]);
     }
}

That would read much cleaner in the callsites.

WebCore/html/HTML5TreeBuilder.cpp:100
 +	if (token.type() == HTML5Token::Uninitialized)
This seems wrong.

WebCore/platform/text/SegmentedString.h:154
 +	void advanceAndASSERTIgnoringCase(UChar expectedCharacter)
We may just want to turn this into a static inline in HTML5Lexer.cpp instead.

I think we need one more round.