[webkit-reviews] review denied: [Bug 15720] [Transforms] Pixel cracks in scaled border-image : [Attachment 56920] Propose patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has denied Damian Kaleta <dkaleta at apple.com>'s
request for review:
Bug 15720: [Transforms] Pixel cracks in scaled border-image
https://bugs.webkit.org/show_bug.cgi?id=15720

Attachment 56920: Propose patch
https://bugs.webkit.org/attachment.cgi?id=56920&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
I don't like the idea of GraphicsContext having two new implementations of
drawTiledImage() that are copies of the existing implementations except that
they take FloatRects instead of IntRects. That is a lot of code duplication,
which is something we try to avoid. The GraphicsContext::drawImage() functions
do a better job of sharing code. I suggest taking a look at them and devising a
way to share as much code as possible.

Also, right now we only call roundToDevicePixels() from graphics-centric
code…in other words, this would be the first patch where we called into that
function directly from the render tree. I wonder if that is a separation that
we want to maintain or not. It might be worth considering having
drawTiledImage() call roundToDevicePixels() on the FloatRect rather than doing
that at the call sites. 

I would be interested to see if Hyatt, Dan, or Darin has an opinion too :-)