[webkit-reviews] review requested: [Bug 38758] [gtk] web fonts not loaded properly in scribd html5 reader : [Attachment 56913] second try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 12:42:07 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 38758: [gtk] web fonts not loaded properly in scribd html5 reader
https://bugs.webkit.org/show_bug.cgi?id=38758

Attachment 56913: second try
https://bugs.webkit.org/attachment.cgi?id=56913&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
After running all the tests I found a number of cases where we would have to
regenerate results, and even a few failures caused by changes in the sizes of
fonts (the new code would fallback all the way to Times New Roman, instead of
matching with FC immediately, as was done before). What this means is
essentially adding more special cases, for well-known font names the tests
expect. I decided to not do that for the japanese font names, though, since the
test result is a passing result, I decided to just generate a new result.


More information about the webkit-reviews mailing list