[webkit-reviews] review granted: [Bug 39594] [v8] ScriptDebugServer should dispatch renderer messages while JS is paused : [Attachment 56881] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 39594: [v8] ScriptDebugServer should dispatch renderer messages while JS is
paused
https://bugs.webkit.org/show_bug.cgi?id=39594

Attachment 56881: patch
https://bugs.webkit.org/attachment.cgi?id=56881&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/bindings/js/ScriptDebugServer.cpp:343
 +	    (this->*callback)(copy[i]);

Nit: I generally do not use such a reflection in the native code. Having
::dispatchDidContinue or a single event listener class with an event type would
be my preference.


WebCore/bindings/v8/ScriptDebugServer.h:85
 +	class ClientMessageLoop {
It might be useful to declare it in a separate header to minimize the amount of
imports on the client.


WebKit/chromium/public/WebDevToolsAgentClient.h:59
 +	class ClientMessageLoop {
Should we name it differently? Like WebKitClientMessageLoop?