[webkit-reviews] review denied: [Bug 38918] add a FancyReviewQueue to upload r? patches to rietveld : [Attachment 56897] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 38918: add a FancyReviewQueue to upload r? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918

Attachment 56897: Patch
https://bugs.webkit.org/attachment.cgi?id=56897&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is looking pretty good.  Some minor comments below.  Probably needs one
more round.

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:629
 +	    self.browser['flag_type-4'] = ('?',)
It's too bad that this will only work for patches uploaded with webkit-patch. 
What's the plan for getting all r? patches uploaded?  Why not start with that?

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:805
 +		self.browser.set_value(comment_text, name='comment', nr=0)
I don't understand how this change relates...

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:336
 +	    comment_text = "Rejecting patch %s from rietveld-queue." %
patch.id()
Why might this happen?	Do we want to send email when it happens?

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:345
 +	def _error_message_for_bug(tool, status_id, script_error):
This function looks like a copy/paste of another function.  Can we share the
implementation?