[webkit-reviews] review denied: [Bug 29899] [Qt] Add a way to stop delayed redirect requests : [Attachment 53857] New WebAction, StopScheduledPageRefresh, to stop all page refresh/redirect requests V...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 08:08:29 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied adawit at kde.org's
request for review:
Bug 29899: [Qt] Add a way to stop delayed redirect requests
https://bugs.webkit.org/show_bug.cgi?id=29899

Attachment 53857: New WebAction, StopScheduledPageRefresh, to stop all page
refresh/redirect requests V...
https://bugs.webkit.org/attachment.cgi?id=53857&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/Api/qwebpage.cpp:2371
 +		QWebFrame *topFrame = mainFrame();
Coding style issue, * is placed wrong.

WebKit/qt/Api/qwebpage.cpp:2373
 +		QListIterator<QWebFrame *> it (topFrame->childFrames());
Should be <QWebFrame*> it(topFrame...

WebKit/qt/Api/qwebpage.cpp:1680
 +	\value StopScheduledPageRefresh Stop all pending page refesh/redirect
requests.
Spelling issue, 'refesh'

r- due to these issues.


More information about the webkit-reviews mailing list