[webkit-reviews] review requested: [Bug 3652] add support for link prefetching : [Attachment 56883] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 06:51:34 PDT 2010


Leon Clarke <leonclarke at google.com> has asked  for review:
Bug 3652: add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652

Attachment 56883: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=56883&action=review

------- Additional Comments from Leon Clarke <leonclarke at google.com>
Note that I've made the feature optional, behind a new ENABLE_LINK_PREFETCH
guard. As a result it's turned off by default, and so I've disabled the new
layout test.

I've made it disabled for 2 reasons, firstly there might possibly be
controversy about whether the feature is a good thing, and secondly in Android
we have a tiny change made outside of the webkit code (specifically we have
some code in our HTTP stack to disable the feature when roaming), and other
platforms might want to consider whether they want similar changes before they
take this.

However, the counter-argument would be that it's a fairly small change and only
downloads things that the page requests are downloaded so it's not worth adding
a new guard for. If people would prefer that it was always on, I'll edit the
patch appropriately.


More information about the webkit-reviews mailing list