[webkit-reviews] review requested: [Bug 36463] Spatial Navigation: make it work with focusable elements in overflow content : [Attachment 56880] patch v5.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 06:36:58 PDT 2010


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 36463: Spatial Navigation: make it work with focusable elements in overflow
content
https://bugs.webkit.org/show_bug.cgi?id=36463

Attachment 56880: patch v5.2
https://bugs.webkit.org/attachment.cgi?id=56880&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
(In reply to comment #13)
> (From update of attachment 56483 [details])
> Not must a review of the actual code, but there goes my comments.

Thank you for looking. Comments addressed.

> > +	     // ### !sameContainerAsCandidate && !sameContainerAsClosest
> 
> ### what does that means? is that a FIXME: ?

It means more like a NOTE: than a FIXME: . see other uses here
http://pastebin.com/BSJrtURx

> Please check if other "isIn" methods exist, or they whether they just use
"in"

only "in" is generally used. Changed accordingly.


More information about the webkit-reviews mailing list