[webkit-reviews] review granted: [Bug 39207] webkit-patch upload needs to pass diff to check-webkit-style : [Attachment 56854] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 39207: webkit-patch upload needs to pass diff to check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=39207

Attachment 56854: patch
https://bugs.webkit.org/attachment.cgi?id=56854&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The invalidation question below is important or else we could upload the wrong
diff.

WebKitTools/Scripts/webkitpy/tool/steps/abstractstep.py: 
 +	    command = [port.script_path(script_name)]
This seems unrelated, but ok.

WebKitTools/Scripts/webkitpy/tool/steps/checkstyle.py:52
 +	    diff = self.cached_lookup(state, "diff")
Please make sure that prepare change log and edit change log correctly
invalidate the diff.  I'm not sure if this really saves much since we need to
recompute the diff after editing the change log anyway.  We need to track the
modified files.