[webkit-reviews] review granted: [Bug 39537] Teach HTML5 parser how to lex comments correctly : [Attachment 56831] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39537: Teach HTML5 parser how to lex comments correctly
https://bugs.webkit.org/show_bug.cgi?id=39537

Attachment 56831: Patch
https://bugs.webkit.org/attachment.cgi?id=56831&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5Token.h:159
 +	    return cachedData();
cachedDataString()?

WebCore/html/HTML5Tokenizer.cpp:46
 +	case HTML5Token::EndOfFile:
Sooooo much better!

WebCore/platform/text/SegmentedString.h:135
 +	void advanceAndASSERT(UChar expectedCharacter)
This will fail in RElease builds.  We need UNUSED_PARAM I think.

Otherwise looks OK.