[webkit-reviews] review granted: [Bug 39525] Make HTML5 parser parse <script>alert("<hi>"); </script> : [Attachment 56779] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39525: Make HTML5 parser parse <script>alert("<hi>");</script>
https://bugs.webkit.org/show_bug.cgi?id=39525

Attachment 56779: Patch
https://bugs.webkit.org/attachment.cgi?id=56779&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5Lexer.cpp:225
 +	    m_bufferedEndTagName.clear();
This seems like a temporary hack we should remove.

WebCore/html/HTML5Lexer.cpp:331
 +		    emitCurrentToken();
Seems strange that we don't return right after this call.  Do we have asserts
in emitCurrentToken that we haven't already emitted?

WebCore/html/HTML5Lexer.cpp:1264
 +	    if (actual[i] != appropriate[i])
Doesn't a UChar buffer compare method exist already?  Or shouldn't we make this
into one?

WebCore/html/HTML5Token.h:128
 +		m_cachedName = AtomicString(StringImpl::adopt(m_data));
This is a good change. :)


Please conisder above comments.  This seems less than perfect but moves us
forward.  100% correctness first, then several rounds of bathing are needed. :)