[webkit-reviews] review denied: [Bug 38400] [Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html : [Attachment 54822] patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 38400: [Qt] Failure on
http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

Attachment 54822: patch
https://bugs.webkit.org/attachment.cgi?id=54822&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Your code replaces the alpha of shadowColor with the alpha of fillStyle. IIRC
both alpha values should be multiplied:

ctx.fillStyle = '#f00';
ctx.fillRect(0, 0, 100, 50);
ctx.fillStyle = 'rgba(64, 0, 0, 0.5)';
ctx.shadowColor = 'rgba(0, 0, 255, 0.5)';
ctx.shadowOffsetY = 50;
ctx.fillRect(0, -50, 100, 50);

Would make the shadowColor (0,0,255,0.25). There is also a DRT test missing.
Can be tested with getImageData, see fast/canvas