[webkit-reviews] review denied: [Bug 38713] Support the labels attribute in labelable form controls : [Attachment 56747] Remove tabs.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 22 09:57:05 PDT 2010
Kent Tamura <tkent at chromium.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 38713: Support the labels attribute in labelable form controls
https://bugs.webkit.org/show_bug.cgi?id=38713
Attachment 56747: Remove tabs.
https://bugs.webkit.org/attachment.cgi?id=56747&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebCore/html/HTMLLabelElement.cpp:178
+ if (attribute->name() == forAttr || attribute->name() == "htmlFor") {
You don't need to handle "htmlFor". HTML5 doesn't define such HTML attribute.
Other parts look ok.
More information about the webkit-reviews
mailing list