[webkit-reviews] review denied: [Bug 10313] xsl:import and document() don't work in stylesheets loaded via XMLHttpRequest : [Attachment 56707] New proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Andreas Wictor
<andreas.wictor at xcerion.com>'s request for review:
Bug 10313: xsl:import and document() don't work in stylesheets loaded via
XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=10313

Attachment 56707: New proposed patch
https://bugs.webkit.org/attachment.cgi?id=56707&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/js/JSDOMImplementationCustom.cpp:30
 +  JSValue JSDOMImplementation::createDocument(ExecState* exec, const ArgList&
args)
Please don't create more custom bindings.  Instead, you should use the
[CallWith=ScriptExecutionContext] IDL attribute.

WebCore/dom/Document.cpp:1285
 +	       
ScriptExecutionContext::setSecurityOrigin(doc->securityOrigin());
I don't understand why we do this.