[webkit-reviews] review denied: [Bug 39465] [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt : [Attachment 56656] Patch for this issue

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 39465: [GTK] webkit_web_view_drag_end should call
EventHandler::dragSourceEndedAt
https://bugs.webkit.org/show_bug.cgi?id=39465

Attachment 56656: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=56656&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+	  [GTK] webkit_web_view_drag_end should call
EventHandler::dragSourceEndedAt
>+	  https://bugs.webkit.org/show_bug.cgi?id=39465

Why should it call it? What happens if you don't? Just because of the names it
makes sense, but we should explain it in the ChangeLog.

>+    event->button.window = static_cast<GdkWindow*>(g_object_ref(
>+	  gdk_display_get_window_at_pointer(display, &x, &y)));

I think the style is to let lines be as long as needed.

>+    event->button.x = x;
>+    event->button.y = y;
>+    event->button.x_root = xRoot;
>+    event->button.y_root = yRoot;
>+    event->button.state = modifiers;
>+
>+    PlatformMouseEvent platformEvent(&event->button);
>+    frame->eventHandler()->dragSourceEndedAt(platformEvent,
>+	  gdkDragActionToDragOperation(context->action));

Same.

r- for missing rationale and because I'm feeling evil.