[webkit-reviews] review granted: [Bug 39516] Add support for parsing the column-span property and getting it into computed style. : [Attachment 56756] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 15:43:13 PDT 2010


mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 39516: Add support for parsing the column-span property and getting it into
computed style.
https://bugs.webkit.org/show_bug.cgi?id=39516

Attachment 56756: Patch
https://bugs.webkit.org/attachment.cgi?id=56756&action=review

------- Additional Comments from mitz at webkit.org
WebCore/css/CSSParser.cpp:1493
 +		validPrimitive = validUnit(value, FNumber | FNonNeg, m_strict)
&& value->fValue == 1.0;
Current style for this is “1” instead of “1.0”.

r=me


More information about the webkit-reviews mailing list