[webkit-reviews] review granted: [Bug 39327] Enforce size constraints on various data structures in JavaScriptCore/wtf. : [Attachment 56744] Proposed fix (same as last time, just updated to not have conflicts with things that have landed).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 15:28:04 PDT 2010


Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 39327: Enforce size constraints on various data structures in
JavaScriptCore/wtf.
https://bugs.webkit.org/show_bug.cgi?id=39327

Attachment 56744: Proposed fix (same as last time, just updated to not have
conflicts with things that have landed).
https://bugs.webkit.org/attachment.cgi?id=56744&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +++ b/JavaScriptCore/wtf/WTFCompileAsserts.cpp

It seems strange to have WTF in the filename here. Also, I think they are
assertions, not "asserts".

If the intent here is to have these be size assertions only, then I think the
file name is not quite right.


More information about the webkit-reviews mailing list