[webkit-reviews] review granted: [Bug 38213] Page up / page down moves edited content for the entire height : [Attachment 56740] latest comments addressed, merged cursor/scroll tests, ahem fonts...

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Zelidrag Hornung
<zelidrag at chromium.org>'s request for review:
Bug 38213: Page up / page down moves edited content for the entire height
https://bugs.webkit.org/show_bug.cgi?id=38213

Attachment 56740: latest comments addressed, merged cursor/scroll tests, ahem
fonts...
https://bugs.webkit.org/attachment.cgi?id=56740&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
r=me with the change below. Thanks for being patient with all this.

WebCore/editing/SelectionController.cpp:174
 +	    if (macStyleScroll)
If settings is null, that means we're in a state where it doesn't matter what
editing behavior we use (e.g. a page transition). The null check is just to
avoid crashing. So you can get rid of the macStyleScroll variable and just do
something like this:
if (m_frame->settings() && m_frame->settings()->editingBehavior() ==
EditingMacBehavior)