[webkit-reviews] review granted: [Bug 39429] Add DOMStringList idl, needed for IndexedDB and for HTML5 drag & drop : [Attachment 56731] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 39429: Add DOMStringList idl, needed for IndexedDB and for HTML5 drag &
drop
https://bugs.webkit.org/show_bug.cgi?id=39429

Attachment 56731: Patch
https://bugs.webkit.org/attachment.cgi?id=56731&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+bool DOMStringList::contains(const String& str) const

There's no need to abbreviate.

+// FIXME: Some consumers of this class may benefit from lazily fetching items
rather
+//	   than creating the list statically as is currently the only option. 
If so,
+//	   you may want to take a look at the original implementation which was
removed
+//	   in r44943 and make this class an interface in a similar way.

I don't think there was anything particularly high-tech in r44943 to quote it,
it's just as easy to write from scratch :). The FIXME should be shorter.

+    ] DOMStringList {
+	 readonly attribute unsigned long length;
+	 DOMString item(in [IsIndex] unsigned long index);
+    };

Please add contains().

+ * 3.	Neither the name of Apple Computer, Inc. ("Apple") nor the names of

There is no "Apple Computer" any more, and we use a two-clause license - please
see <http://webkit.org/coding/bsd-license.html>.

r=me with these fixes.